Open
Conversation
github-actions
Bot
added
[Package] Editor
mirka
commented
Apr 28, 2026
Comment on lines
14
to
15
| margin-left: - $grid-unit-40; | ||
| margin-right: - $grid-unit-40; |
Member
Author
There was a problem hiding this comment.
The footer margin offsets for both dialogs probably broke due to #73334, where the Modal paddings changed. There may be more similar breakage elsewhere. I'm thinking these would be good places to try migrating to the @wordpress/ui Dialog, as they are safe and have concrete bugs that would be fixed by the Dialog.Footer.
Contributor
There was a problem hiding this comment.
Soudns good! Do you want to try the migration yourself, as an excuse to have someone different from me using/testing Dialog ?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
changed the title
|
Size Change: 0 B Total Size: 7.82 MB ℹ️ View Unchanged
|
|
Flaky tests detected in ea28e9d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25081916236
|
ciampo
approved these changes
Apr 30, 2026
Comment on lines
14
to
15
| margin-left: - $grid-unit-40; | ||
| margin-right: - $grid-unit-40; |
Contributor
There was a problem hiding this comment.
Soudns good! Do you want to try the migration yourself, as an excuse to have someone different from me using/testing Dialog ?
Contributor
There was a problem hiding this comment.
Looks like a new package release happened after opening this PR — we'll need to rebase/merge trunk and create a new CHANGELOG entry in the Unreleased section
| padding-right: $grid-unit-40; | ||
| border-top: 1px solid $gray-300; | ||
| z-index: z-index(".editor-start-page-options__modal__actions"); | ||
| z-index: 1; |
Contributor
There was a problem hiding this comment.
Similar to #77807 (comment) re. missing context of the z-index values and how they coordinate with other values.
Suggested change
| z-index: 1; | |
| // Sit above the scrolling patterns list so its content slides behind the footer. | |
| z-index: 1; |
or we could even retain the original comment
Suggested change
| z-index: 1; | |
| // Ensure modal footer actions appear above the modal's scrolling content. | |
| z-index: 1; |
| padding-right: $grid-unit-40; | ||
| border-top: 1px solid $gray-300; | ||
| z-index: z-index(".editor-start-template-options__modal__actions"); | ||
| z-index: 1; |
Contributor
There was a problem hiding this comment.
Suggested change
| z-index: 1; | |
| // Sit above the scrolling patterns list so its content slides behind the footer. | |
| z-index: 1; |
or
Suggested change
| z-index: 1; | |
| // Ensure modal footer actions appear above the modal's scrolling content. | |
| z-index: 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Inlines the start page and start template options modal footer z-index values that were previously defined in the shared
z-index()helper.Why?
These stacking values only describe layering inside their own modal layouts. Keeping them local makes the shared z-index map smaller and easier to reserve for cross-component stacking concerns.
How?
Removes the start options modal footer entries from
packages/base-styles/_z-index.scssand replaces the correspondingz-index()calls with localz-index: 1values in the component styles.Testing Instructions
npm run lint:css -- packages/base-styles/_z-index.scss packages/editor/src/components/start-template-options/style.scss packages/editor/src/components/start-page-options/style.scss.Choose a patternmodal opens.Always show starter patterns for new pagescheckbox stays above the modal content.Choose a patternmodal opens.Skipbutton stays above the modal content.Screenshots or screencast