Skip to content

Editor: Inline pattern chooser z-index values #77772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 4 commits into from
Apr 30, 2026
Merged

Editor: Inline pattern chooser z-index values #77772

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d250ec6
Inline start options z-index values
mirka Apr 28, 2026
ea28e9d
Add changelog
mirka Apr 28, 2026
566fe0f
Merge branch 'trunk' into inline-start-options-z-index
mirka Apr 30, 2026
051e55a
Apply suggestions from code review
mirka Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/base-styles/CHANGELOG.md
View file
Open in desktop
Comment thread
mirka marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Breaking Changes

- Remove the following entries from the `z-index()` helper ([#77619](https://github.com/WordPress/gutenberg/pull/77619), [#77620](https://github.com/WordPress/gutenberg/pull/77620), [#77621](https://github.com/WordPress/gutenberg/pull/77621), [#77714](https://github.com/WordPress/gutenberg/pull/77714), [#77715](https://github.com/WordPress/gutenberg/pull/77715), [#77717](https://github.com/WordPress/gutenberg/pull/77717)):
- Remove the following entries from the `z-index()` helper ([#77619](https://github.com/WordPress/gutenberg/pull/77619), [#77620](https://github.com/WordPress/gutenberg/pull/77620), [#77621](https://github.com/WordPress/gutenberg/pull/77621), [#77714](https://github.com/WordPress/gutenberg/pull/77714), [#77715](https://github.com/WordPress/gutenberg/pull/77715), [#77717](https://github.com/WordPress/gutenberg/pull/77717), [#77772](https://github.com/WordPress/gutenberg/pull/77772)):
- `.block-editor-block-contextual-toolbar`
- `.block-editor-block-list__block {core/image aligned wide or fullwide}`
- `.block-editor-block-list__block::before`
Expand Down Expand Up @@ -32,6 +32,8 @@
- `.edit-site-template-panel__replace-template-modal`
- `.edit-widgets-header`
- `.edit-widgets-sidebar {greater than small}`
- `.editor-start-page-options__modal__actions`
- `.editor-start-template-options__modal__actions`
- `.interface-complementary-area .components-panel`
- `.interface-complementary-area .components-panel__header`
- `.wp-block-template-part__placeholder-preview-filter-input`
Expand Down
4 changes: 0 additions & 4 deletions packages/base-styles/_z-index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,6 @@ $z-layers: (
// Title needs to appear above other UI the section content.
".edit-site-sidebar-navigation-screen__title-icon": 1,

// Ensure modal footer actions appear above modal contents
".editor-start-template-options__modal__actions": 1,
".editor-start-page-options__modal__actions": 1,

// Ensure checkbox + actions don't overlap table header
".dataviews-view-table thead": 1,

Expand Down
3 changes: 1 addition & 2 deletions packages/editor/src/components/start-page-options/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@use "@wordpress/base-styles/colors" as *;
@use "@wordpress/base-styles/mixins" as *;
@use "@wordpress/base-styles/variables" as *;
@use "@wordpress/base-styles/z-index" as *;

$actions-height: 72px;

Expand All @@ -17,7 +16,7 @@ $actions-height: 72px;
padding-left: $grid-unit-40;
padding-right: $grid-unit-40;
border-top: 1px solid $gray-300;
z-index: z-index(".editor-start-page-options__modal__actions");
z-index: 1;
Comment thread
mirka marked this conversation as resolved.
}

.block-editor-block-patterns-list {
Expand Down
3 changes: 1 addition & 2 deletions packages/editor/src/components/start-template-options/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@use "@wordpress/base-styles/colors" as *;
@use "@wordpress/base-styles/mixins" as *;
@use "@wordpress/base-styles/variables" as *;
@use "@wordpress/base-styles/z-index" as *;

$actions-height: 92px;

Expand All @@ -17,7 +16,7 @@ $actions-height: 92px;
padding-left: $grid-unit-40;
padding-right: $grid-unit-40;
border-top: 1px solid $gray-300;
z-index: z-index(".editor-start-template-options__modal__actions");
z-index: 1;
Comment thread
mirka marked this conversation as resolved.
}

.block-editor-block-patterns-list {
Expand Down
Loading