Interactivity API: Fix popover bind hydration#77797
Open
cbravobernal wants to merge 2 commits intotrunkfrom
Open
Interactivity API: Fix popover bind hydration#77797cbravobernal wants to merge 2 commits intotrunkfrom
cbravobernal wants to merge 2 commits intotrunkfrom
Conversation
cbravobernal
added
the
[Type] Bug
cbravobernal
force-pushed
the
worktree-77766-popover-bind
branch
from
0c5d3b7 to
8dd0b92
Compare
|
Size Change: +132 B (0%) Total Size: 7.82 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 1a1d819. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25115682072
|
cbravobernal
force-pushed
the
worktree-77766-popover-bind
branch
from
43f546c to
e02f5a1
Compare
cbravobernal
requested review from
DAreRodz,
ajitbohra,
luisherranz,
nerrad and
ntwb
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
luisherranz
reviewed
Apr 29, 2026
cbravobernal
force-pushed
the
worktree-77766-popover-bind
branch
from
686b36f to
1a1d819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #77766
Updates
@wordpress/interactivityto Preact10.29.1and aligns Interactivity API hydration-timewp-bindattribute handling with current Preact behavior, including support fordata-wp-bind--popover.Why?
data-wp-bind--popoverwas not setting thepopoverattribute correctly during hydration because the Interactivity API mirrors Preact's DOM attribute handling for hydration, and that mirrored logic did not include Preact's newer special handling forpopover.The lockfile also kept Gutenberg on an older Preact release even though the existing dependency range allowed newer versions, so the dependency and related test expectations needed to be updated together.
How?
preactdependency for@wordpress/interactivityto10.29.1and updatespackage-lock.json.input.valuewhen rerenderingnull/undefined.packages/interactivity/src/directives.tsxso hydration excludespopoverfrom the DOM property assignment path, removes it forfalse,null, andundefined, preserves string values, and serializestrueas a present empty attribute.data-wp-bind--popovervalues:true,false,null,undefined,auto,manual, andhint.Testing Instructions
data-wp-bind › attribute hydration › value is correctly hydrated for different valuestest passes.data-wp-bind › attribute hydration › popover is correctly hydrated for different valuestest passes.Testing Instructions for Keyboard
Not applicable. This does not change user-facing UI or keyboard interactions.
Screenshots or screencast
Not applicable.
Use of AI Tools
This PR was prepared with assistance from AI coding agents in Pi. The generated code, tests, documentation review, and PR description were reviewed by the contributor.