Add declare( strict_types = 1 ) to all PHP files

[meravi]

Adds declare( strict_types = 1 ); to all PHP source files across the monorepo.
Fixes #2348

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: meravi <ravikhadka@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[meravi]

@westonruter would appreciate a quick look when you have a moment 🙏

[mukeshpanchal27]

Should be after the plugin info.

[meravi]

Good catch, thanks! Moved it after the plugin header.

[westonruter]

Suggested change

	declare( strict_types = 1 );
	declare( strict_types = 1 );

[westonruter]

Thanks for the PR.

In addition to the trivial PHPCS issue which I left a suggestion for, there are unit test failures related to the new strict types. This will need to be fixed.

[westonruter]

@meravi why remove the strict types? The underlying type problem should be fixed so the strict types can exist in all the files.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.33%. Comparing base (404dcd1) to head (3b461d2).

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk    #2424   +/-   ##
=======================================
  Coverage   69.33%   69.33%           
=======================================
  Files          90       90           
  Lines        7749     7749           
=======================================
  Hits         5373     5373           
  Misses       2376     2376           

Flag	Coverage Δ
multisite	69.33% <100.00%> (ø)
single	35.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[meravi]

I reverted it temporarily for testing, but it’s added back now.
@westonruter

[westonruter]

@meravi ok, you can see that the unit tests are still failing. Once they are passing this will be ready for review.

[meravi]

@meravi ok, you can see that the unit tests are still failing. Once they are passing this will be ready for review.

I’ve fixed the issues, and the unit tests are now passing 🟢
Ready for review when you have a moment :)