Skip to content

Add declare( strict_types = 1 ) to all PHP files #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meravi wants to merge 12 commits into
base: trunk
Choose a base branch
from
Open

Add declare( strict_types = 1 ) to all PHP files #2424

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a07e94d
Add declare( strict_types = 1 ) to all PHP files
meravi Mar 20, 2026
9992f0b
Move strict types declaration after plugin header
meravi Mar 24, 2026
d011161
Fix strict_types declaration placement and PHPCS issue
meravi Mar 25, 2026
ec38bb6
Remove strict_types from auto-sizes entry files
meravi Mar 25, 2026
773ce2d
Keep strict_types only in class files
meravi Mar 25, 2026
fc8721e
Revert "Keep strict_types only in class files"
meravi Mar 25, 2026
b4b053e
Revert "Remove strict_types from auto-sizes entry files"
meravi Mar 25, 2026
1b25236
Fix strict types handling for autoload options size query
meravi Mar 26, 2026
06783fa
Update plugins/performance-lab/includes/site-health/audit-autoloaded-…
meravi Mar 26, 2026
eed4772
Update plugins/performance-lab/includes/site-health/audit-autoloaded-…
meravi Mar 26, 2026
b01a800
Update plugins/performance-lab/includes/site-health/audit-autoloaded-…
meravi Mar 26, 2026
3b461d2
Merge branch 'trunk' into add-strict-types
mukeshpanchal27 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions performance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
* @package performance
*/

declare( strict_types = 1 );

if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
Expand Down
2 changes: 2 additions & 0 deletions plugins/auto-sizes/auto-sizes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
* @package auto-sizes
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/auto-sizes/hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 1.0.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/dominant-color-images/class-dominant-color-image-editor-gd.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
* @since 1.0.0
*/

declare( strict_types = 1 );

/**
* WordPress Image Editor Class for Image Manipulation through GD
* with dominant color detection.
Expand Down
2 changes: 2 additions & 0 deletions plugins/dominant-color-images/class-dominant-color-image-editor-imagick.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
* @since 1.0.0
*/

declare( strict_types = 1 );

/**
* WordPress Image Editor Class for Image Manipulation through Imagick
* with dominant color detection.
Expand Down
2 changes: 2 additions & 0 deletions plugins/dominant-color-images/helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* @since 1.0.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/dominant-color-images/hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* @since 1.0.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/dominant-color-images/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
* @package dominant-color-images
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/embed-optimizer/class-embed-optimizer-tag-visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.2.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/embed-optimizer/helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @package embed-optimizer
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/embed-optimizer/hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @package embed-optimizer
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/embed-optimizer/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
* @package embed-optimizer
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/image-prioritizer/class-image-prioritizer-background-image-styled-tag-visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/image-prioritizer/class-image-prioritizer-img-tag-visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/image-prioritizer/class-image-prioritizer-tag-visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/image-prioritizer/class-image-prioritizer-video-tag-visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
* @since 0.2.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/image-prioritizer/helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/image-prioritizer/hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/image-prioritizer/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
* @package image-prioritizer
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-data-validation-exception.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-element.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.7.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-html-tag-processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.1
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-link-collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.3.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-strict-url-metric.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.6.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-tag-visitor-context.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.4.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-tag-visitor-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.3.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-template-optimization-context.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 1.0.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-url-metric-group-collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-url-metric-group.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-url-metric.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/class-od-visited-tag-state.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 1.0.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/deprecated.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
* @noinspection PhpUnused
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/detection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
* @package optimization-detective
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/optimization.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/site-health.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 1.0.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/storage/class-od-rest-url-metrics-store-endpoint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/storage/class-od-storage-lock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/storage/class-od-url-metric-store-request-context.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.7.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/storage/class-od-url-metrics-post-type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/storage/data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
Expand Down
2 changes: 2 additions & 0 deletions plugins/optimization-detective/uninstall.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* @since 0.1.0
*/

declare( strict_types = 1 );

// If uninstall.php is not called by WordPress, bail.
if ( ! defined( 'WP_UNINSTALL_PLUGIN' ) ) {
exit; // @codeCoverageIgnore
Expand Down
Loading
Loading