fix node build #887
fix node build #887
Conversation
…as failing in that
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Node.js build incompatibility issue by updating dependencies and modifying the CI configuration.
- Bumps "@google-cloud/logging" from "^11.0.0" to "^11.2.0".
- Updates the Node.js version matrix in the CI workflow to accommodate Node.js 24 compatibility.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/psoxy-test/package.json | Updates the Google Cloud Logging dependency version. |
| .github/workflows/ci-tools.yaml | Adjusts Node.js version matrix and related comments for clarity. |
Files not reviewed (1)
- tools/psoxy-test/package-lock.json: Language not supported
| # 21 released Oct 2023; superseded in May 2024 | ||
| # latest is the 22 as of May 2024; 23 coming in Oct 2024 | ||
| node-version: [ 18, 20, 21, latest] | ||
| # latest is the 24 as of May 2025; 23 maintained until June 2025 or so |
There was a problem hiding this comment.
[nitpick] Consider removing or clarifying the phrase 'or so' to provide a precise timeframe in the comment.
| # latest is the 24 as of May 2025; 23 maintained until June 2025 or so | |
| # latest is the 24 as of May 2025; 23 maintained until approximately June 2025 |
Copilot uses AI. Check for mistakes.
|
eh, nm - that didn't fix anything ... same problem still dep on same version of |
FYI googleapis/google-auth-library-nodejs#1544 -> googleapis/google-auth-library-nodejs#1650 (comment) and also ruffle-rs/ruffle#20362 with the links provided in the comments |
|
@eschultink I think we can close this one, right? |
Fixes
Change implications
alpha, requires major version change