Skip to content

fix node build #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix node build #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/ci-tools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ jobs:
# 16 is min version recommended to users; but unmaintained since 2023-10
# 18 released 2022-04-19 - maintained until June 2025
# 20 maintained until June 2026
# 21 released Oct 2023; superseded in May 2024
# latest is the 22 as of May 2024; 23 coming in Oct 2024
node-version: [ 18, 20, 21, latest]
# latest is the 24 as of May 2025; 23 maintained until June 2025 or so
Copy link
Preview

Copilot AI May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider removing or clarifying the phrase 'or so' to provide a precise timeframe in the comment.

Suggested change
# latest is the 24 as of May 2025; 23 maintained until June 2025 or so
# latest is the 24 as of May 2025; 23 maintained until approximately June 2025

Copilot uses AI. Check for mistakes.

node-version: [ 18, 20, 22, 23, latest ]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
31 changes: 24 additions & 7 deletions tools/psoxy-test/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/psoxy-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@aws-sdk/client-cloudwatch-logs": "^3.350.0",
"@aws-sdk/client-s3": "^3.350.0",
"@aws-sdk/credential-providers": "^3.351.0",
"@google-cloud/logging": "^11.0.0",
"@google-cloud/logging": "^11.2.0",
"@google-cloud/storage": "^7.12.1",
"@stdlib/assert-is-gzip-buffer": "^0.1.1",
"aws4": "^1.11.0",
Expand Down
Loading