Skip to content

feat: Choose writer by cluster communication#2830

Merged
kuznetsss merged 50 commits intoXRPLF:developfrom
kuznetsss:1974_Choose_writer_from_communication
Jan 21, 2026
Merged

feat: Choose writer by cluster communication#2830
kuznetsss merged 50 commits intoXRPLF:developfrom
kuznetsss:1974_Choose_writer_from_communication

Conversation

@kuznetsss
Copy link
Collaborator

Fixes #1974

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 85.38462% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.04%. Comparing base (0ebbaaa) to head (3ad9d78).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/etl/ETLService.cpp 69.09% 7 Missing and 10 partials ⚠️
src/app/ClioApplication.cpp 0.00% 13 Missing ⚠️
src/cluster/ClioNode.cpp 90.47% 0 Missing and 2 partials ⚠️
src/cluster/impl/RepeatedTask.hpp 90.90% 0 Missing and 2 partials ⚠️
src/util/async/context/impl/Execution.hpp 77.77% 0 Missing and 2 partials ⚠️
src/app/Stopper.hpp 0.00% 0 Missing and 1 partial ⚠️
src/cluster/WriterDecider.cpp 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2830      +/-   ##
===========================================
+ Coverage    81.86%   82.04%   +0.18%     
===========================================
  Files          382      391       +9     
  Lines        14494    14623     +129     
  Branches      7951     8001      +50     
===========================================
+ Hits         11865    11997     +132     
+ Misses        1451     1447       -4     
- Partials      1178     1179       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuznetsss kuznetsss force-pushed the 1974_Choose_writer_from_communication branch from 1b1110f to 0737efc Compare January 13, 2026 15:57
@kuznetsss kuznetsss force-pushed the 1974_Choose_writer_from_communication branch from 59e08b7 to 7efc947 Compare January 16, 2026 14:11
@kuznetsss kuznetsss force-pushed the 1974_Choose_writer_from_communication branch from 7efc947 to edc1dc9 Compare January 16, 2026 15:36
@kuznetsss kuznetsss force-pushed the 1974_Choose_writer_from_communication branch from ec8c39c to 8b02c3f Compare January 16, 2026 15:48
@kuznetsss kuznetsss requested a review from godexsoft January 16, 2026 17:19
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a few small things to improve that i noted. Otherwise it's an amazing feature, really well done 🙇

@kuznetsss kuznetsss requested a review from godexsoft January 20, 2026 14:50
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 :rage1:

@kuznetsss kuznetsss merged commit a72e5a1 into XRPLF:develop Jan 21, 2026
49 of 51 checks passed
@kuznetsss kuznetsss deleted the 1974_Choose_writer_from_communication branch January 21, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Choose writer from nodes communication

2 participants