-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix casting issues in RPC CLIs, remove proof from book_offers
#6044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvadari
wants to merge
55
commits into
develop
Choose a base branch
from
mvadari/fix-bad-cast
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 51 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
17e4d38
Fix index for iLimit in RPCCall.cpp
mvadari e66cfab
fix tests, more cleanup
mvadari 9fb088c
remove debug statements
mvadari 403bfaa
fix account_tx
mvadari fb5d878
fix can_delete
mvadari 9e23d50
fix connect
mvadari f1f2cc7
fix get_counts
mvadari 2116ea6
fix tx_history
mvadari 400cd02
remove debug lines
mvadari 711d765
clean up book_offers
mvadari 8852594
fix test
mvadari efa2a1b
simplify tests
mvadari c326a80
re-remove debug lines
mvadari 3e07a64
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 96287e2
remove jss::proof
mvadari 5154649
remove now-unneeded comments
mvadari 50f418f
add consts
mvadari fd2f2b1
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 69dba2e
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 2d53099
update changelog
mvadari eca65c0
respond to comments (mostly more consts)
mvadari df52266
fix tests
mvadari 100ad8b
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 2b61b22
Update API-CHANGELOG.md
mvadari d78bc9e
Update src/xrpld/rpc/detail/RPCCall.cpp
mvadari eb681ad
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 36c4060
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari acd3417
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari d4c2154
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 39dfcdf
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari b4fcf80
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari e42f243
respond to comments
mvadari ff4125f
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari bdc8dc3
fix build
mvadari 949ba8e
check int limit
mvadari 840e430
Merge commit '92046785d1fea5f9efe5a770d636792ea6cab78b' into mvadari/…
mvadari a227fe8
Merge commit '5f638f55536def0d88b970d1018a465a238e55f4' into mvadari/…
mvadari 37e3f03
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari e2a273d
respond to comments
mvadari e46b346
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari d24f40a
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 83137a2
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari d2f3d39
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari 72a6148
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari 77989d9
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari 040231a
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari 90d7d38
Merge commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c' into mvadari/…
mvadari 319eb41
Merge commit '2c1fad1023' into mvadari/fix-bad-cast
mvadari 4e298ef
fix formatting
mvadari 45b35ae
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari e9a0f1f
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 1868979
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari 26bdc71
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari c7f9904
Update src/xrpld/rpc/detail/RPCCall.cpp
mvadari c7b39df
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry says
book_offersproofwas removed from the “RPC and CLI versions”, but the PR description states there are no changes for HTTPS/WS API users. If the server-side RPC still accepts and ignores unknown fields (includingproof), consider rewording this to clarify it’s removed from the CLI and no longer processed internally (but not a breaking change / not rejected for HTTP/WS callers).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvadari ditto