Skip to content

fix casting issues in RPC CLIs, remove proof from book_offers #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvadari wants to merge 55 commits into
base: develop
Choose a base branch
from
+257 −452
Open

fix casting issues in RPC CLIs, remove proof from book_offers #6044

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
17e4d38
Fix index for iLimit in RPCCall.cpp
mvadari Nov 17, 2025
e66cfab
fix tests, more cleanup
mvadari Nov 17, 2025
9fb088c
remove debug statements
mvadari Nov 17, 2025
403bfaa
fix account_tx
mvadari Nov 17, 2025
fb5d878
fix can_delete
mvadari Nov 17, 2025
9e23d50
fix connect
mvadari Nov 17, 2025
f1f2cc7
fix get_counts
mvadari Nov 17, 2025
2116ea6
fix tx_history
mvadari Nov 17, 2025
400cd02
remove debug lines
mvadari Nov 17, 2025
711d765
clean up book_offers
mvadari Nov 17, 2025
8852594
fix test
mvadari Nov 17, 2025
efa2a1b
simplify tests
mvadari Nov 17, 2025
c326a80
re-remove debug lines
mvadari Nov 17, 2025
3e07a64
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Nov 18, 2025
96287e2
remove jss::proof
mvadari Nov 17, 2025
5154649
remove now-unneeded comments
mvadari Nov 20, 2025
50f418f
add consts
mvadari Nov 20, 2025
fd2f2b1
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Nov 20, 2025
69dba2e
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Nov 20, 2025
2d53099
update changelog
mvadari Nov 20, 2025
eca65c0
respond to comments (mostly more consts)
mvadari Nov 20, 2025
df52266
fix tests
mvadari Nov 20, 2025
100ad8b
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Dec 2, 2025
2b61b22
Update API-CHANGELOG.md
mvadari Dec 23, 2025
d78bc9e
Update src/xrpld/rpc/detail/RPCCall.cpp
mvadari Dec 23, 2025
eb681ad
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Dec 23, 2025
36c4060
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Jan 5, 2026
acd3417
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Jan 7, 2026
d4c2154
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Jan 13, 2026
39dfcdf
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Jan 21, 2026
b4fcf80
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Jan 22, 2026
e42f243
respond to comments
mvadari Jan 22, 2026
ff4125f
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Jan 22, 2026
bdc8dc3
fix build
mvadari Jan 22, 2026
949ba8e
check int limit
mvadari Jan 22, 2026
840e430
Merge commit '92046785d1fea5f9efe5a770d636792ea6cab78b' into mvadari/…
mvadari Jan 28, 2026
a227fe8
Merge commit '5f638f55536def0d88b970d1018a465a238e55f4' into mvadari/…
mvadari Jan 28, 2026
37e3f03
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Jan 28, 2026
e2a273d
respond to comments
mvadari Jan 30, 2026
e46b346
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Jan 30, 2026
d24f40a
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Feb 3, 2026
83137a2
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari Feb 4, 2026
d2f3d39
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari Feb 6, 2026
72a6148
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari Feb 10, 2026
77989d9
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari Feb 12, 2026
040231a
Merge remote-tracking branch 'upstream/develop' into mvadari/fix-bad-…
mvadari Feb 13, 2026
90d7d38
Merge commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c' into mvadari/…
mvadari Feb 24, 2026
319eb41
Merge commit '2c1fad1023' into mvadari/fix-bad-cast
mvadari Feb 24, 2026
4e298ef
fix formatting
mvadari Feb 24, 2026
45b35ae
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Feb 24, 2026
e9a0f1f
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Feb 26, 2026
1868979
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Feb 27, 2026
26bdc71
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Feb 27, 2026
c7f9904
Update src/xrpld/rpc/detail/RPCCall.cpp
mvadari Mar 2, 2026
c7b39df
Merge branch 'develop' into mvadari/fix-bad-cast
mvadari Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/xrpl/protocol/jss.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,6 @@ JSS(ports); // out: NetworkOPs
JSS(previous); // out: Reservations
JSS(previous_ledger); // out: LedgerPropose
JSS(price); // out: amm_info, AuctionSlot
JSS(proof); // in: BookOffers
JSS(propose_seq); // out: LedgerPropose
JSS(proposers); // out: NetworkOPs, LedgerConsensus
JSS(protocol); // out: NetworkOPs, PeerImp
Expand Down
Loading