Lending Protocol: minor bug-fixes #6101
Open
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Exclude LogicError lines in ApplyView.cpp (specifically directory operations) from code coverage. - Replace the ability to set the next page on a new directory page with an assert, because nothing uses it right now. - Early return with success for batch inner transactions in preflight2.
…iminez/lending-XLS-66-2 * XRPLF/ximinez/develop-nolending: Revert "Implement Lending Protocol (unsupported) (5270)" Implement Lending Protocol (unsupported) (5270)
- Originally defined as uint64_t, but the testIssuerLoan() test called it with a negative number, causing an overflow to a very large number that in some circumstances could be silently cast back to an int64_t, but might not be. I believe this is UB, and we don't want to rely on that.
Tapanito
changed the title
Tapanito
force-pushed
the
tapanito/lending-check-error
branch
2 times, most recently
from
d258a0c to
55d2502
Compare
Tapanito
force-pushed
the
tapanito/lending-check-error
branch
from
55d2502 to
7f7fda5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ximinez/lending-XLS-66-ongoing #6101 +/- ##
================================================================
- Coverage 79.1% 79.0% -0.0%
================================================================
Files 839 839
Lines 71376 71379 +3
Branches 8336 8339 +3
================================================================
+ Hits 56424 56425 +1
- Misses 14952 14954 +2
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ximinez
force-pushed
the
ximinez/lending-XLS-66-2
branch
from
335b9be to
c953073
Compare
ximinez
changed the base branch from
ximinez/lending-XLS-66-2
to
ximinez/lending-XLS-66-ongoing
Tapanito
force-pushed
the
tapanito/lending-check-error
branch
from
335a1ac to
372fa71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes small bugs: