Add alias for SetRegularKey, SetHook, SetRemarks [DO NOT MERGE]#595
Open
Add alias for SetRegularKey, SetHook, SetRemarks [DO NOT MERGE]#595
SetRegularKey, SetHook, SetRemarks [DO NOT MERGE]#595Conversation
Contributor
|
what effect does this have on server definitions? Should we modify server_definitions maybe to include duplicates for the aliased types? |
Member
Author
yes, need to add processing to server_definition. Also, we need to consider at what point the value of TxJson.TransactionType returned by commands like tx command should be changed to the Alias value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)