Skip to content

Add alias for SetRegularKey, SetHook, SetRemarks [DO NOT MERGE] #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tequdev wants to merge 2 commits into
base: dev
Choose a base branch
from
+24 −0
Open

Add alias for SetRegularKey, SetHook, SetRemarks [DO NOT MERGE] #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60e97d9
add alias name for `SetRegularKey`, `SetHook`, `SetRemarks` not tested
tequdev Oct 17, 2025
8fed04a
Merge branch 'dev' into tt-alias
RichardAH Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/ripple/protocol/KnownFormats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,21 @@ class KnownFormats
return item;
}

Item const&
addAlias(char const* name, KeyType type)
{
auto const item = findByType(type);
if (!item)
{
LogicError(
std::string("Unknown type for item '") + name +
"': " + std::to_string(type));
}

names_[name] = item;
return *item;
}

private:
std::string name_;

Expand Down
6 changes: 6 additions & 0 deletions src/ripple/protocol/impl/TxFormats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ TxFormats::TxFormats()
},
commonFields);

addAlias(jss::RegularKeySet, ttREGULAR_KEY_SET);

add(jss::Payment,
ttPAYMENT,
{
Expand Down Expand Up @@ -326,6 +328,8 @@ TxFormats::TxFormats()
},
commonFields);

addAlias(jss::HookSet, ttHOOK_SET);

add(jss::ClaimReward,
ttCLAIM_REWARD,
{
Expand Down Expand Up @@ -465,6 +469,8 @@ TxFormats::TxFormats()
},
commonFields);

addAlias(jss::RemarksSet, ttREMARKS_SET);

add(jss::Clawback,
ttCLAWBACK,
{
Expand Down
3 changes: 3 additions & 0 deletions src/ripple/protocol/jss.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ JSS(Payment); // transaction type.
JSS(PaymentChannelClaim); // transaction type.
JSS(PaymentChannelCreate); // transaction type.
JSS(PaymentChannelFund); // transaction type.
JSS(RegularKeySet); // transaction type.
JSS(RemarksSet); // transaction type.
JSS(Remit); // transaction type.
JSS(RippleState); // ledger type.
JSS(SLE_hit_rate); // out: GetCounts.
Expand All @@ -135,6 +137,7 @@ JSS(SetFlag); // field.
JSS(SetRegularKey); // transaction type.
JSS(SetHook); // transaction type.
JSS(Hook); // ledger type.
JSS(HookSet); // transaction type.
JSS(HookDefinition); // ledger type.
JSS(HookState); // ledger type.
JSS(HookStateData); // field.
Expand Down
Loading