Free trace offload buffer objects when trace offload is destructed#48
Open
richard-byron wants to merge 3 commits intoXilinx:masterfrom
Open
Free trace offload buffer objects when trace offload is destructed#48richard-byron wants to merge 3 commits intoXilinx:masterfrom
richard-byron wants to merge 3 commits intoXilinx:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously HalDevice::free was a NOP. Buffer objects still will get freed, but not until the program exits. This change implements free so that buffer objects will be released at the point free is called.
This was causing problems with some tests running out of memory for trace buffers. This change doesn't necessarily prevent that, but seems like good practice anyway.
This also changes continuousOffload so that it won't attempt to initialize trace buffers again if a call to initReadTrace has already failed. This change is not strictly necessary, but makes the code slightly easier to follow and the initial failure point easier to identify. initReadTrace is always called before startOffload (which creates the thread that continuousOffload is the entry point for), so calling it a second time should just result in a second failure.