Skip to content

Free trace offload buffer objects when trace offload is destructed #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richard-byron wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Free trace offload buffer objects when trace offload is destructed #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88e2be4
Free trace buffers
richard-byron Apr 21, 2026
e43dab6
Removing whitespace change
richard-byron Apr 21, 2026
1028038
Removing whitespace change take 2
richard-byron Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion profile/device/aie_trace/aie_trace_offload.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,8 @@ void AIETraceOffload::startOffload()

void AIETraceOffload::continuousOffload()
{
if (!bufferInitialized && !initReadTrace()) {
if (!bufferInitialized) {
// initReadTrace failed to allocate the buffer, cannot offload
offloadFinished();
return;
}
Expand Down
4 changes: 3 additions & 1 deletion profile/device/hal_device/xdp_hal_device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,9 @@ size_t HalDevice::alloc(size_t size, uint64_t memoryIndex)

void HalDevice::free(size_t)
{
return;
if(!id) return;
size_t boIndex = id - 1;
xrt_bos[boIndex] = xrt::bo();
}

void* HalDevice::map(size_t id)
Expand Down