HIP: Fix kernel_start null-args handling.#9763
Open
svup-xilinx wants to merge 1 commit intoXilinx:masterfrom
Open
HIP: Fix kernel_start null-args handling.#9763svup-xilinx wants to merge 1 commit intoXilinx:masterfrom
svup-xilinx wants to merge 1 commit intoXilinx:masterfrom
Conversation
Add validation in kernel_start constructor to handle null args safely: Fetch kernel argument metadata once If args is null and kernel expects arguments, throw invalid value If args is null and kernel has zero arguments, return early Reuse cached kernel args for argument binding loop Signed-off-by: Srikanth Vuppala <120363307+svup-xilinx@users.noreply.github.com>
svup-xilinx
requested review from
chvamshi-xilinx,
sonals and
stsoe
as code owners
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Add validation in kernel_start constructor to handle null args safely:
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Fixed a null-args validation gap in HIP kernel launch setup: when kernelParams (args) was null, constructor logic could proceed into argument processing for kernels that actually require arguments, which could lead to invalid launch behavior.
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested on Windows Strix machine with negative tests of unit tests in testcases-v2 repo.
Documentation impact (if any)
NA