Skip to content

HIP: Fix kernel_start null-args handling. #9763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chvamshi-xilinx merged 1 commit into from
May 2, 2026
+8 −1
Merged

HIP: Fix kernel_start null-args handling. #9763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/runtime_src/hip/core/event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,15 @@ kernel_start::kernel_start(std::shared_ptr<function> f, void** args)
r = xrt::run(k);

using karg = xrt_core::xclbin::kernel_argument;
auto kernel_args = xrt_core::kernel_int::get_args(k);
if (!args) {
throw_invalid_value_if(!kernel_args.empty(),
"kernel args pointer is null but kernel expects arguments");
return;
}

int idx = 0;
for (const auto& arg : xrt_core::kernel_int::get_args(k)) {
for (const auto& arg : kernel_args) {
// non index args are not supported, this condition will not hit in case of HIP
throw_invalid_value_if(arg->index == karg::no_index, "function has invalid argument");

Expand Down
Loading