Skip to content

Add C++ driver support #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 58 commits into
base: dev
Choose a base branch
from

Conversation

LinusJungemann
Copy link

Adds support for the C++ driver for FINN https://github.com/eki-project/finn-cpp-driver
The C++ driver itself is added as a submodule to FINN.

Current v1.0 driver release note: https://github.com/eki-project/finn-cpp-driver/releases/tag/v1.0

@LinusJungemann
Copy link
Author

Bumped driver version to v1.1: https://github.com/eki-project/finn-cpp-driver/releases/tag/v1.1

@auphelia
Copy link
Collaborator

For reference, there should be an additional Jenkins test which tests the driver on the board, similar to: https://github.com/Xilinx/finn/blob/dev/docker/jenkins/test_bnn_hw_pytest.py

@LinusJungemann
Copy link
Author

The C++ driver depends on #1210, so that I do not have to duplicate some of the builder options. In the meantime, there are still some details that I will polish up a bit for nicer integration.

I have now moved both drivers into a single step called step_make_driver. If pynq_driver is in the generate_outputs list, then the old driver will be used. If cpp_driver is in the list, then the C++ driver is used. Additionally, the C++ driver version can be selected in the build config using "latest" or a commit hash.

Copy link
Collaborator

@preusser preusser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LinusJungemann!
This looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants