[AIEX] OuterLoopPipeliner Bug fix 2#1073
Closed
F-Stuckmann wants to merge 2 commits into
Closed
Conversation
Pins the pre-fix crash: when the exit block is reached directly by the latch and shares an LCSSA phi with the preheader-bypass edge, deleting the original latch asserts on the missing phi entry.
When the exit block is reached directly by the latch and shares an LCSSA phi with the preheader-bypass edge, add a clone-latch incoming instead of renaming the original-latch entry, leaving it for removeFromCFG to drop cleanly. Converts the shared-exit test to the pipelined output.
F-Stuckmann
requested review from
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
| ; RUN: -o - %s 2>&1 | FileCheck %s | ||
|
|
||
| ; BASELINE (pre-fix): the outer loop's exit block is shared between the | ||
| ; preheader-bypass edge (entry -> exit) and the loop back-edge, so the live-out |
Collaborator
There was a problem hiding this comment.
That's the exit edge, not the back edge?
martien-de-jong
approved these changes
Jul 9, 2026
martien-de-jong
left a comment
martien-de-jong
left a comment
Collaborator
There was a problem hiding this comment.
Nice and clean. Local repair at each separate stage. The highway to software reuse.
Collaborator
Author
|
I am splitting the OLP refactor into NFC parts that reimplement the bugs and the fixes on top of the refactor. that will be clearer to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHI node crash fix.