Revert Hotfixes in SubReg Coalescing and Intrinsic Attributes #735
+85
−130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally these changes were introduced to limit performance impacts, when partially defined SubRegisters are spilled.
This is caused by the InlineSpiller.cpp only being able to spill full registers.
So instead of spilling the defined SubRegisters, Inlinespiller will spill the whole Register (also the undefined components).
Without Register Sequence generation only the defined Registers are spilled and only later register sequenced.
This later register sequencing however is suboptimal and may introduce moves.
Thus these hotifxes limited
With a proper SubRegister Spilling (#713), these hotfixes can be removed.