[MLIR][TOSA] guard against illegal rw with quant types#827
Open
tr00 wants to merge 1 commit into
Open
Conversation
tr00
requested review from
ehsan-toosi,
jorickert,
ljfitz,
roberteg16 and
ttjost
as code owners
jorickert
reviewed
Mar 9, 2026
| @@ -26,6 +29,18 @@ namespace tosa { | |||
| // Utility functions to support quantization handling in Tosa. | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| /// Returns true if the type is a quantized tensor. | |||
| inline bool isQuantizedTensor(Type type) { | |||
Contributor
There was a problem hiding this comment.
Lets move this to the .cpp
| @@ -26,6 +29,18 @@ namespace tosa { | |||
| // Utility functions to support quantization handling in Tosa. | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| /// Returns true if the type is a quantized tensor. | |||
| inline bool isQuantizedTensor(Type type) { | |||
| auto tensorType = mlir::dyn_cast<RankedTensorType>(type); | |||
Contributor
There was a problem hiding this comment.
cast or getElementTypeOrSelf
tr00
force-pushed
the
tarik.TOSA-quant-types
branch
from
ca3ea4a to
2db5043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TOSA dialect allows building with quant types from the Quant dialect, but some rewrites such as abs(abs(x)) --> abs(x) are not semantic-preserving when x is e.g. tensor<...x!quant.uniform<...>>.
Added guards and LIT tests for abs and negate canonicalization.