[AIE2P]/[AIE2PS] Mark float conversion intrinsics as having default attributes#988
Open
khallouh wants to merge 1 commit into
Open
[AIE2P]/[AIE2PS] Mark float conversion intrinsics as having default attributes#988khallouh wants to merge 1 commit into
khallouh wants to merge 1 commit into
Conversation
…aving default attributes Without these, LLVM needs to be conservative for some intrinsics and assume they never return. Adding the default attributes enables more optimizations.
khallouh
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
Collaborator
|
@F-Stuckmann attempted this before but was running into unfortunate performance regressions: #681 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these, LLVM needs to be conservative for some intrinsics and assume they never return. Adding the default attributes enables more optimizations.