address Copilot review comments

Author: andrej

lib/Dialect/AIEX/Utils/AIEUtils.cpp

@@ -211,6 +211,7 @@ void AIEX::emitScratchpadParamsFile(ModuleOp moduleOp, llvm::raw_ostream &os) {
     std::string typeStr;
     llvm::raw_string_ostream ts(typeStr);
     p.getType().print(ts);
+    ts.flush();
     StringRef kindStr =
         p.getKind().value() == AIEX::ScratchpadParameterKind::Addr ? "addr"
                                                                    : "core";

tools/aiecc/ExecutionEngine.h

@@ -370,8 +370,11 @@ inline void writeCheckpoint(llvm::ArrayRef<EdgeBase *> cutEdges,
         destName = std::to_string(i) + "_" + base;
       llvm::SmallString<256> dest(dir);
       llvm::sys::path::append(dest, destName);
-      if (llvm::sys::fs::copy_file(src, dest))
+      if (std::error_code ec = llvm::sys::fs::copy_file(src, dest)) {
+        llvm::errs() << "aiecc: checkpoint failed to copy '" << src << "' to '"
+                     << dest << "': " << ec.message() << "\n";
         continue;
+      }
       frontier.push_back(llvm::json::Object{
           {"name", e->name}, {"key", it->key}, {"path", destName}});
     }

tools/aiecc/SidecarFiles.h

@@ -277,12 +277,16 @@ makeFullElfConfigJson(const Node<OpInModule<xilinx::AIE::DeviceOp>> &devices,
 
     llvm::json::Array instances;
     devOp.walk([&](xilinx::AIE::RuntimeSequenceOp seq) {
-      // One `.bin` per runtime sequence, keyed "<device>_<sequence>".
+      // One `.bin` per runtime sequence, keyed "<device>_<sequence>". Only
+      // sequences that were actually lowered to a control-code binary have an
+      // entry in `instsPaths`; skip the rest (e.g. filtered out via
+      // `--sequence-name`) so we don't emit an instance with an empty
+      // TXN_ctrl_code_file, which is invalid for `aiebu-asm -t aie2_config`.
       auto instsIt = instsPaths.find(npuSeqKey(devName, seq.getSymName()));
-      std::string instsPath =
-          instsIt == instsPaths.end() ? "" : instsIt->second;
-      instances.push_back(
-          O{{"id", seq.getSymName().str()}, {"TXN_ctrl_code_file", instsPath}});
+      if (instsIt == instsPaths.end())
+        return;
+      instances.push_back(O{{"id", seq.getSymName().str()},
+                            {"TXN_ctrl_code_file", instsIt->second}});
     });
     if (instances.empty())
       continue;

tools/aiecc/Tools.h

@@ -126,7 +126,7 @@ inline mlir::LogicalResult assemblePdi(const Item<std::string> &bifItem,
 // directory name under `<aietools>/tps/lnx64/`. Empty for unsupported targets.
 inline std::string getChessTarget(llvm::StringRef aieTarget) {
   std::string t = aieTarget.lower();
-  if (t == "aie2")
+  if (t == "aie2" || t == "aieml")
     return "target_aie_ml";
   if (t == "aie2p")
     return "target_aie2p";