vendor_eudsl: remove np.bool post-install patch#3007
Merged
Conversation
The root cause (np.bool used as a dict key in eudsl's mlir/extras/util.py) has been fixed upstream in llvm/eudsl. Now that eudsl ships np.bool_ directly, the post-install text-replacement workaround in vendor_eudsl.py is no longer needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
erwei-xilinx
approved these changes
Mar 27, 2026
hunhoffe
changed the title
Collaborator
Author
|
eudsl change is merged; this is now waiting for when eudsl is updated at next llvm update. |
hunhoffe
requested review from
abisca,
andrej,
jackl-xilinx and
jgmelber
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the post-install text-replacement workaround that patched
np.bool → np.bool_in the vendored eudsl code. The fix will hopefully live upstream in llvm/eudsl (pending llvm/eudsl#374).Also remove the
prefix/util_pathderivation lines that existed solely to support this patch.Note: update
python/requirements.txtto pin the eudsl release that includes the upstream fix before merging.@erwei-xilinx -- just tagging you so you see this too!