Guard transaction-to-MLIR conversion when no parent aie.device exists#3122
Closed
Copilot wants to merge 2 commits into
Closed
Guard transaction-to-MLIR conversion when no parent aie.device exists#3122Copilot wants to merge 2 commits into
aie.device exists#3122Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code for review comment
Guard transaction-to-MLIR conversion when no parent May 29, 2026
aie.device exists
Collaborator
|
wrong branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convertTransactionOpsToMLIRassumed the builder insertion point was always nested underaie.deviceand unconditionally dereferenced the derivedDeviceOp. This change makes that failure mode explicit and returns a cleanLogicalResultfailure with a diagnostic instead of crashing.What changed
DeviceOpfrom the current insertion point.aie.deviceis found.failure()before any use ofdevice.getLoc()/device.getBody().Behavioral impact
Example