Skip to content

Extend create-cores location-preservation test coverage to match documented synthesized ops#3123

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-extend-the-checks
Closed

Extend create-cores location-preservation test coverage to match documented synthesized ops#3123
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-extend-the-checks

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

The review flagged that test/create-cores/loc_preservation.mlir documented location checks for more synthesized ops than it actually asserted. This updates that test to align checks with the full op list described in the test intent.

  • Problem summary

    • The test comment claimed location forwarding coverage for aie.tile, aie.mem, aie.core, aie.end, aie.flow, aie.dma_start, aie.dma_bd, aiex.useToken, and aie.next_bd, but FileCheck only covered a subset.
  • Changes made

    • Expanded --aie-create-cores checks
      • Added FileCheck assertions for synthesized aie.tile, aie.mem, and aie.end locations.
      • Kept existing checks for aie.core and aie.buffer.
    • Expanded --aie-lower-memcpy checks
      • Added FileCheck assertions for synthesized aie.dma_start and aie.next_bd locations.
      • Kept existing checks for aie.flow, aie.dma_bd, and aiex.useToken.
    • Comment alignment
      • Updated nearby comment wording so the documented coverage matches enforced assertions.
  • Example snippet

    // CHECK-DAG: aie.tile({{.*}}) loc(#[[CALLLOC:loc[0-9]*]])
    // CHECK-DAG: aie.mem({{.*}})
    // CHECK-DAG: aie.end loc(#[[CALLLOC]])
    
    // CHECK-DAG: aie.dma_start({{.*}}) loc(#[[MCLOC]])
    // CHECK-DAG: aie.next_bd {{.*}} loc(#[[MCLOC]])

Copilot AI changed the title [WIP] Fix code by extending the checks Extend create-cores location-preservation test coverage to match documented synthesized ops May 29, 2026
Copilot AI requested a review from fifield May 29, 2026 22:31
@fifield
Copy link
Copy Markdown
Collaborator

fifield commented May 29, 2026

wrong branch

@fifield fifield closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants