[DO NOT MERGE YET] Bump clone-llvm.sh to ROCm/llvm-project, retire mlirDistroRocm.yml#3326
Draft
jgmelber wants to merge 1 commit into
Draft
[DO NOT MERGE YET] Bump clone-llvm.sh to ROCm/llvm-project, retire mlirDistroRocm.yml#3326jgmelber wants to merge 1 commit into
jgmelber wants to merge 1 commit into
Conversation
Follow-up to #3324 (repointed mlirDistro.yml at ROCm/llvm-project). Bumps utils/clone-llvm.sh to the commit already validated end-to-end in #3314 (46fcb339, ROCm/llvm-project), so every downstream consumer (mlirAIEDistro.yml, buildAndTestPythons.yml, buildAndTestRyzenAI.yml, and the rest) starts resolving the ROCm-built wheel from the mlir-distro release tag. mlirDistroRocm.yml is retired: mlirDistro.yml now builds from ROCm directly, so the standalone ROCm-only pipeline is redundant. update-llvm.yml's biweekly schedule is paused (workflow_dispatch kept) since utils/update_llvm_version.py is hardcoded to upstream llvm/llvm-project and would otherwise silently propose reverting this migration. DO NOT MERGE until both of the following are true: 1. #3324 is merged AND mlirDistro.yml has been dispatched with LLVM_COMMIT=46fcb339fb61119b337f973c7ca9e710a319fdd0 pinned explicitly, so mlir-distro actually has a published wheel matching this commit/datetime (23.0.0.2026071017+46fcb339) — otherwise every consumer 404s immediately, which is exactly what happened when this was bundled into #3324 originally. 2. #3323 (validate the ROCm wheel on Ryzen AI self-hosted runners) has run and passed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3324 (repoints
mlirDistro.ymlatROCm/llvm-project, not yet merged). This is the second stage of the migration: it flips every downstream consumer over to the ROCm-built MLIR by bumping the shared version pin.utils/clone-llvm.sh: bumpedLLVM_PROJECT_COMMIT/DATETIMEto the commit already validated end-to-end in [TEST] Add ROCm migration test workflow #3314 (46fcb339,ROCm/llvm-project) — this is the single file every downstream consumer (mlirAIEDistro.yml,buildAndTestPythons.yml,buildAndTestMulti.yml,buildAndTestVitis.yml,buildAndTestAieTools.yml,buildAndTestAieToolsHsaBuildOnly.yml,buildAndTestRyzenAISw.yml,buildRyzenWheels.yml,lintAndFormat.yml,generateDocs.yml,buildAndTestRyzenAI.yml) reads via--get-wheel-versionto know whichmlirwheel version topip installfrom themlir-distrorelease tag..github/workflows/mlirDistroRocm.ymldeleted — retired now thatmlirDistro.yml(via Repoint mlirDistro.yml at ROCm/llvm-project #3324) builds from ROCm directly, making the standalone pipeline redundant..github/workflows/update-llvm.yml: paused the biweekly automatic schedule (keptworkflow_dispatch).utils/update_llvm_version.pyis hardcoded tollvm/llvm-project(and cross-checkstorch-mlir/eudslcompatibility windows that don't apply to the ROCm fork) — left running, it would silently open PRs proposing to revert this migration within ~2 weeks. Making the updater ROCm-fork-aware and re-enabling the schedule is tracked in Make update-llvm.yml ROCm-fork-aware (re-enable auto LLVM updates post-migration) #3336.DO NOT MERGE until
mlirDistro.ymlhas been manually dispatched withLLVM_COMMIT=46fcb339fb61119b337f973c7ca9e710a319fdd0pinned explicitly (not auto-latest), so themlir-distrorelease actually has a published wheel matching23.0.0.2026071017+46fcb339. Skipping this step is exactly what broke Repoint mlirDistro.yml at ROCm/llvm-project #3324 when this was all one PR — every consumer 404s immediately if the version this PR pins to doesn't already exist undermlir-distro.Opened as a draft for that reason — flip to ready-for-review once both gates above are satisfied.
Test plan
mlir-distroconfirmed to have a23.0.0.2026071017+46fcb339wheelaie2-4colandaie2p-8colbuildAndTestPythons,mlirAIEDistro, etc.) and confirm they now resolve/install the ROCm-built wheel successfully🤖 Generated with Claude Code