Enable control packet reconfiguration tests on ci#1275
Open
erwei-xilinx wants to merge 1 commit intoXilinx:mainfrom
Open
Enable control packet reconfiguration tests on ci#1275erwei-xilinx wants to merge 1 commit intoXilinx:mainfrom
erwei-xilinx wants to merge 1 commit intoXilinx:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables control packet reconfiguration tests on CI by uncommenting previously disabled test commands and updating the test infrastructure to support both NPU1 and NPU2 devices. The changes allow the tests to run with device-specific configurations rather than being disabled.
Changes:
- Uncommented and enabled test commands in
.littest files that were previously disabled - Added device selection support to the Python test script via command-line argument
- Created device-specific base MLIR files for NPU1 and NPU2 configurations
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/xrt/23_ctrlpkt_config/run_npu2_peano.lit | Enabled NPU2 peano test commands and updated to use device-specific base file |
| test/xrt/23_ctrlpkt_config/run_npu1_peano.lit | Enabled NPU1 peano test commands and updated to use device-specific base file |
| test/xrt/23_ctrlpkt_config/run_npu1_chess.lit | Enabled NPU1 chess test commands and updated to use device-specific base file |
| test/xrt/23_ctrlpkt_config/base_npu2.mlir | Added NPU2-specific base configuration file |
| test/xrt/23_ctrlpkt_config/base_npu1.mlir | Updated header comment to reflect correct filename |
| test/xrt/23_ctrlpkt_config/aie.py | Added device parameter support to enable NPU1/NPU2 selection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.