Address Filters Menu Feedback Items#1451
Merged
Merged
Conversation
Contributor
|
I think the layering changes to fix the difficulty ring section from drawing over the filter menu got lost somewhere. Otherwise this looks good to me! |
Contributor
Author
|
Nope, that was in #1453. Since it was actually a bug that people had brought up, I wanted it in a more focused PR. |
Contributor
|
Oh, did I forget to merge Narrator: Yes, wyrdough did a stupid |
XaiaX
pushed a commit
to XaiaX/YARG
that referenced
this pull request
May 26, 2026
* Change "Difficulty" to "Intensity" in `FiltersMenu` (cherry picked from commit 90f8b07) * Removed "Advanced" setting indicator from screens outside of `SettingsMenu` (cherry picked from commit 88f7c41) * Show Intensity option in `FiltersMenu` for every unique instrument (cherry picked from commit 784585a) * Add "Instrumental" filter option for "Number of Vocal Parts" (cherry picked from commit 6104e6e) * Made filter options wrapping generic and applied to Sources and Playlists Also fixed merge resolution errors (cherry picked from commit 4a1e119) * Fix things lost in cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SettingsMenunote: This change was originally part of #1413. I've split it out as they were only very loosely related.