Aggregate Drums Score/Sort/Filter#1413
Open
Dansla116 wants to merge 7 commits into
Open
Conversation
Contributor
|
All sounds reasonable except that I do have concerns about old hashes being removed from playlists since it's possible they might come back later. Some people do store their libraries on removable disks, after all. |
Contributor
Author
|
That's a fair concern and not something I considered. Dare I suggest to add a toggle? |
Dansla116
force-pushed
the
aggregate-drums
branch
from
7e8e115 to
0bc505e
Compare
This was referenced Apr 21, 2026
Merged
Dansla116
changed the title
Contributor
Author
|
This was getting unwieldy and I realized there were like four different things going on. So I've cherry-picked just the changes related to the Aggregated Drums changes and force-pushed to this branch. I've started new branches and opened new PRs for the other changes. |
Dansla116
force-pushed
the
aggregate-drums
branch
from
0bc505e to
d0d309f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When controller is set to MIDI Drumkit, show scores for all drum types and treat them all as one instrument. Order of preference is Elite > Pro > 5-Lane > 4-Lane. (see image 1)
This resolves #1262.
note: This originally included the changes in #1451, #1452, and #1453. I've split those out as they were only very loosely related.