Remove Dead Playlist Hashes#1452
Open
Dansla116 wants to merge 2 commits into
Open
Conversation
Contributor
|
I'm going to hold off on this until after 0.15 since I have no good ideas yet... |
…k and library is rescanned (cherry picked from commit 3185230)
3d27fd7 to
1181faa
Compare
Contributor
Author
|
Feedback Item: Made a change so when manually editing a playlist, it removes the dead hashes from only that playlist. Editing can include re-ordering (either with left/right, or using the "Sort by: ..." from the popup menu), adding or removing a song from the playlist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting or modifying a song on disc (and therefore, removing/changing song hash), that inaccessible, dead hash was still on the playlist file.
For normal users, this resulted in empty spaces in the playlist manager in game. You could press left/right to re-order your playlist, and it would sometimes look like nothing is happening because you're moving songs around the dead hashes that no longer exist.
For power users/developers, the playlist in game will say one number, and the playlist file on disc will include all the dead hashes and show a higher number.
Made a change so when rescanning your library, it removes the dead hashes from existing playlists.(see feedback item below)note: This change was originally part of #1413. I've split it out as they were only very loosely related.