Fix: ValueError handling for empty files scanning with only-allowlist…#938
Open
Roman-Malinowski wants to merge 2 commits intoYelp:masterfrom
Open
Fix: ValueError handling for empty files scanning with only-allowlist…#938Roman-Malinowski wants to merge 2 commits intoYelp:masterfrom
Roman-Malinowski wants to merge 2 commits intoYelp:masterfrom
Conversation
tocic
reviewed
Dec 28, 2025
Comment on lines
+209
to
+211
| except ValueError: | ||
| log.warning(f'Unable to scan file: {filename}. Please ignore if file is empty.') | ||
| return |
There was a problem hiding this comment.
I would suggest checking if lines: above instead - that way we'll be specifically addressing the issue (as opposed to any ValueError exception) and we won't need to execute the line yield from _scan_for_allowlisted_secrets_in_lines(enumerate(lines, start=1), filename) at all
Author
There was a problem hiding this comment.
Thanks for the feedback, I added the suggested modifications.
Update scanning logic to check if lines are not empty before scanning for allowlisted secrets.
tocic
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #936
Bug fix: Handling the ValueError when running
detect-secrets scan --only-allowlistedin a directory containing empty filesA ValueError is raised as described in issue #936
A warning is raised, and the scan continues.