Skip to content

Fix: ValueError handling for empty files scanning with only-allowlist… #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roman-Malinowski wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

Fix: ValueError handling for empty files scanning with only-allowlist… #938

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cc9526
Fix: ValueError handling for empty files scanning with only-allowlist…
Roman-Malinowski Oct 24, 2025
c27c721
Replaced try/except with length test
Roman-Malinowski Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions detect_secrets/core/scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ def scan_for_allowlisted_secrets_in_file(filename: str) -> Generator[PotentialSe
except IOError:
log.warning(f'Unable to open file: {filename}')
return
except ValueError:
log.warning(f'Unable to scan file: {filename}. Please ignore if file is empty.')
return
Copy link
Copy Markdown

@tocic tocic Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest checking if lines: above instead - that way we'll be specifically addressing the issue (as opposed to any ValueError exception) and we won't need to execute the line yield from _scan_for_allowlisted_secrets_in_lines(enumerate(lines, start=1), filename) at all

Copy link
Copy Markdown
Author

@Roman-Malinowski Roman-Malinowski Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I added the suggested modifications.



def scan_for_allowlisted_secrets_in_diff(diff: str) -> Generator[PotentialSecret, None, None]:
Expand Down