Skip to content

Fix gap between icon and title on search appearance on RTL #22322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented May 30, 2025

Context

  • We want to fix a bug in search appearance on rtl that is visible also on the ai generator.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the icon on search appearance would not be aligned when on a right-to-left locale.
  • [@yoast/search-metadata-previews 0.0.1] Fixes a bug where the icon on search appearance would not be aligned when on a right-to-left locale.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Edit a post when site language is English.
  • Check there is 12 px space between the icon in the search appearance and the title.
  • Click on "Use AI" ( on local env, use fake-ai-generator-api-response.patch)
  • Check the space between the icon and title is still 12 px.
  • Change to rtl language like Hebrew and repeat the checks.
    RTL:
    Screenshot 2025-05-30 at 15 52 29
    Screenshot 2025-05-30 at 15 52 49
    LTR:
    Screenshot 2025-05-30 at 15 53 30
    Screenshot 2025-05-30 at 15 53 36

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@vraja-pro vraja-pro added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label May 30, 2025
@vraja-pro vraja-pro changed the title add space as gap instead of margin Fix gap between icon and title on search appearance May 30, 2025
@vraja-pro vraja-pro changed the title Fix gap between icon and title on search appearance Fix gap between icon and title on search appearance on RTL May 30, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 305b209353d1b44e73a07aeb20dfd9991ac854a4

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.843%

Totals Coverage Status
Change from base Build f6f2785717466a1641053d2ffddc74e45e4e66ab: 0.0%
Covered Lines: 29750
Relevant Lines: 58582

💛 - Coveralls

@igorschoester igorschoester self-assigned this Jun 10, 2025
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit fc7ba24 into feature/ai-generator-in-free Jun 10, 2025
20 checks passed
@igorschoester igorschoester deleted the fix-search-appearance-icon-rtl branch June 10, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants