Skip to content

Fix gap between icon and title on search appearance on RTL #22322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
+5 −3
Merged

Fix gap between icon and title on search appearance on RTL #22322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa6ff16
add space as gap instead of margin
vraja-pro May 30, 2025
6afc216
fix snapshot test
vraja-pro May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/search-metadata-previews/src/snippet-preview/SnippetPreview.js
View file
Original file line number Diff line number Diff line change
@@ -180,6 +180,7 @@ const BaseUrlOverflowContainer = styled( BaseUrl )`
padding-top: 1px;
line-height: 20px;
vertical-align: bottom;
column-gap: 12px;
`;
BaseUrlOverflowContainer.displayName = "BaseUrlOverflowContainer";

@@ -197,7 +198,6 @@ const UrlBaseContainer = styled.span`
const FaviconContainer = styled.div`
width: 28px;
height: 28px;
margin-right: 12px;
border-radius: 50px;
display: flex;
align-items: center;
6 changes: 4 additions & 2 deletions packages/search-metadata-previews/tests/__snapshots__/SnippetEditorTest.js.snap
View file
Original file line number Diff line number Diff line change
@@ -165,6 +165,8 @@ exports[`SnippetEditor Desktop mode and should switch to mobile 1`] = `
padding-top: 1px;
line-height: 20px;
vertical-align: bottom;
-webkit-column-gap: 12px;
column-gap: 12px;
}

.c12 {
@@ -184,7 +186,6 @@ exports[`SnippetEditor Desktop mode and should switch to mobile 1`] = `
.c10 {
width: 28px;
height: 28px;
margin-right: 12px;
border-radius: 50px;
display: -webkit-box;
display: -webkit-flex;
@@ -627,6 +628,8 @@ exports[`SnippetEditor Mobile mode 1`] = `
padding-top: 1px;
line-height: 20px;
vertical-align: bottom;
-webkit-column-gap: 12px;
column-gap: 12px;
}

.c11 {
@@ -646,7 +649,6 @@ exports[`SnippetEditor Mobile mode 1`] = `
.c9 {
width: 28px;
height: 28px;
margin-right: 12px;
border-radius: 50px;
display: -webkit-box;
display: -webkit-flex;