Skip to content

docs: Fix docs about encodings for PIV signing command #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

YourMJK
Copy link
Contributor

@YourMJK YourMJK commented Jun 7, 2025

YourMJK added 2 commits June 7, 2025 18:15
DER encoding was missing the mandatory NULL value (05 00) to ensure signatures are compatible with OpenSSL/BoringSSL
@DennisDyallo DennisDyallo requested a review from Copilot June 9, 2025 07:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for the PIV signing command to correct the DER encoding details and fix a typo in the APDU signature description.

  • Adjusts the documented DER encoding from 49 to 51 bytes by including the mandatory NULL (05 00)
  • Updates the block description and the number of 0xFF bytes for the YubiKey command
  • Corrects a typo in the hex sequence of the RSA-2048 signature in the APDU documentation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/users-manual/application-piv/commands.md Updated DER encoding details for PIV signing, including mandatory NULL byte
docs/users-manual/application-piv/apdu/auth-sign.md Fixed typo in the hexadecimal representation for the RSA-2048 signature

@DennisDyallo
Copy link
Collaborator

LGTM

@dainnilsson

@DennisDyallo DennisDyallo requested a review from dainnilsson June 9, 2025 07:27
@DennisDyallo DennisDyallo changed the title Fix docs about encodings for PIV signing command docs: Fix docs about encodings for PIV signing command Jun 10, 2025
@DennisDyallo DennisDyallo merged commit d831a10 into Yubico:develop Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants