Skip to content

Add zemu tests #5

Draft
abenso wants to merge 3 commits intofeat/uifrom
feat/zemu
Draft

Add zemu tests #5
abenso wants to merge 3 commits intofeat/uifrom
feat/zemu

Conversation

@abenso
Copy link
Copy Markdown
Collaborator

@abenso abenso commented May 23, 2025 •
edited by zboto Bot
Loading

Added Zemu tests
Enabled fuzzer
Added try test

🔗 zboto Link

github-advanced-security[bot]
github-advanced-security AI found potential problems May 23, 2025
View reviewed changes
Comment thread app/src/borsh.c
ZEMU_LOGF(100, "%s\n", print);
#else
printf("%s\n", str);
// printf("%s\n", str);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Copilot Autofix

AI 11 months ago

To resolve the issue, we should either reinstate the commented-out code or remove it entirely. Since the #else block in the print_string function is currently empty, reinstating the code would restore functionality for non-LEDGER_SPECIFIC environments. This approach ensures that the function behaves consistently across different configurations.

Steps to fix:

  1. Reinstate the commented-out printf statement in the #else block of the print_string function.
  2. Ensure the reinstated code is properly formatted and functional.
Suggested changeset 1
app/src/borsh.c

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/app/src/borsh.c b/app/src/borsh.c
--- a/app/src/borsh.c
+++ b/app/src/borsh.c
@@ -121,3 +121,3 @@
 #else
-    // printf("%s\n", str);
+    printf("%s\n", str);
 #endif
EOF
@@ -121,3 +121,3 @@
#else
// printf("%s\n", str);
printf("%s\n", str);
#endif
Copilot is powered by AI and may make mistakes. Always verify output.
@abenso abenso force-pushed the feat/zemu branch 2 times, most recently from 80cea44 to ec43c02 Compare June 10, 2025 10:25
@abenso abenso force-pushed the feat/zemu branch 3 times, most recently from 2faa07d to 28ed48b Compare June 10, 2025 14:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jul 2, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/zemu

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abenso @github-advanced-security