fix(ego-lint): reduce Tiling Shell false positives

[ZviBaratz]

Summary

• R-VER49-08/11 ternary guard: Same-line get_maximized ? suppresses maximize/unmaximize flags warnings — these are intentional version-compat shims
• Minified JS threshold: Require 3+ lines >500 chars instead of 1 — single long lines in compiled TypeScript are not minification

Closes #16

Test plan

• Updated fixture: gnome49-compat@test with ternary maximize/unmaximize methods
• Updated fixture: minified-js@test with 3 long lines (still triggers)
• Assertions verify: R-VER49-08/11 suppressed with ternary guard, minified-js still detected
• bash tests/run-tests.sh passes (512 assertions)

🤖 Generated with Claude Code

[ZviBaratz]

Code review

Found 1 issue:

1. guard-window: 0 is rejected by the apply-patterns.py validator (guard-window must be >= 1). At runtime, max(1, int(...)) silently clamps 0 to 1, so the guard works in practice — but running python3 apply-patterns.py --validate rules/patterns.yaml will now emit two ERRORs and exit non-zero. Using guard-window: 1 achieves the same behavior (current line is always checked regardless of window size) and passes validation.

gnome-extension-reviewer/rules/patterns.yaml

Lines 1059 to 1062 in 22b1e9d

	min-version: 49
	guard-pattern: "get_maximized\\s*\\?"
	guard-window: 0

gnome-extension-reviewer/rules/patterns.yaml

Lines 1088 to 1091 in 22b1e9d

	fix: "Call unmaximize() without the MaximizeFlags parameter"
	guard-pattern: "get_maximized\\s*\\?"
	guard-window: 0

Validator logic that rejects it:

gnome-extension-reviewer/skills/ego-lint/scripts/apply-patterns.py

Lines 220 to 224 in 22b1e9d

	gw_int = int(gw)
	if gw_int < 1:
	print(f"ERROR: {rid}: guard-window must be >= 1, got {gw}")
	errors += 1
	except (ValueError, TypeError):

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[ZviBaratz]

PR Review Summary

Critical Issues (1)

set -euo pipefail regression in minified JS detection (ego-lint.sh:427,439)

The old code ran awk inside an if condition (exempt from set -e). The new bare command substitution long_line_count=$(awk ...) will abort the entire script silently if awk fails (permission denied, TOCTOU race, etc.). The 2>/dev/null swallows the error message.

Fix — add || true to both occurrences:

long_line_count=$(awk 'length > 500 { n++ } END { print n+0 }' "$f" 2>/dev/null || true)

Important Issues (1)

Missing boundary test for minified JS threshold. The fixture tests 3 lines (triggers), but there's no test that 2 long lines does not trigger — which is the exact behavioral contract this PR introduces. A regression lowering the threshold back would go undetected.

Suggestions

• No test for multi-line ternary guard (where get_maximized ? is on the previous line, trigger on the next). Low risk since guard-window is battle-tested by other rules.
• The lib/ directory code path for minified detection has zero test coverage. Mechanical copy of top-level code, so low risk.

Strengths

• Guard pattern logic is correct — guard-window: 1 is the minimum valid value
• Both R-VER49-08 and R-VER49-11 retain independent un-guarded fixtures, catching overly-broad guards
• Test placement in gnome49-compat@test (which already fails on other rules) proves the guard doesn't mask unrelated violations
• Commit messages and docs follow project conventions

[ZviBaratz]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}