fix(ego-lint): reduce Just Perfection false positives#29
Closed
fix(ego-lint): reduce Just Perfection false positives#29
Conversation
Field test #10 on Just Perfection (most popular GNOME extension) revealed 6 false positives and a duplicate-detection bug. Fixes: - License check: add src/ parent-dir fallback (FAIL → PASS) - UUID-dir match: skip when dirname is "src" (src/ layout) - isLocked guard: sessionMode.isLocked is always a guard pattern, not lock screen functionality — exempt from impossible-state and session-modes-consistency checks - Prototype-override: deduplicate by (file, prototype) to avoid counting both override and restore - Comment-density: raise threshold from 40% to 50% to accommodate well-documented hand-written code (JSDoc-heavy) Results: FAILs 3→2, WARNs 414→408 (remaining 400 R-SLOP addressed by PR #23) Closes #26, closes #27, closes #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
2 tasks
ZviBaratz
added a commit
that referenced
this pull request
Mar 4, 2026
## Summary - **Tiling Shell field test report** (session #29): Compiled TypeScript extension, 64 files / 11K lines — identified constructor-from-enable FPs, arrow fn definition FPs, ternary guard FPs, single-line minification FP - **Media Controls field test report** (session #30): MPRIS D-Bus controller, src/ layout, 17 files / 5K lines — identified onDestroy() cleanup recognition gap, provenance threshold too conservative, src/ metadata.json fallback missing - **Calibration lessons #14-18** added to docs/internal/README.md (compiled TypeScript patterns) - **Development Workflow** section added to CLAUDE.md (issue→branch→PR convention) - **Repository Workflow** section added to CLAUDE.md Closes #19 ## Test plan - [x] Documentation-only changes — no code affected - [x] Field test reports follow existing template format 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
ZviBaratz
added
ego-lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Field test #10 on Just Perfection (most popular GNOME extension, GNOME 45–50, 7 JS files,
src/layout) revealed 6 false positives and a duplicate-detection bug:ego-lint.shnow checks parent dir for LICENSE when scanningsrc/directory (FAIL → PASS)check-metadata.pyskips meaningless UUID-dir match when dirname issrcsessionMode.isLockedis always a guard pattern (reading lock state to decide behavior), not lock screen functionality — removed fromimpossible-stateandsession-modes-consistencycheckscheck-lifecycle.pydeduplicates by(file, prototype)key to avoid counting both the override and restore (5 → 3 warnings)check-quality.py— well-documented hand-written code with JSDoc hits 40% legitimatelyResults: FAILs 3→2, WARNs 414→408. Remaining 400 R-SLOP-01/02 JSDoc warnings addressed by PR #23 (provenance threshold).
Closes #26, closes #27, closes #28
Test plan
src-license-fallback@test,islocked-guard@test,proto-override-dedup@testai-slop@testfixture (isLocked→currentMode !== 'unlock-dialog')🤖 Generated with Claude Code