Skip to content

Conversation

@efecarranza
Copy link
Contributor

Changelog

Add RemoteGSM Implementation
Abstract methods on GSM


/// @inheritdoc IGhoReserve
function use(uint256 amount) external {
require(_entities.contains(msg.sender), "NOT_ENTITY");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this check actually needed? same in restore

  • when removing the entity, we check used and limit is 0.
  • when adding an entity, it can start with 0 limit.
  • use check limit, so only existent entities with non-zero limit are allowed
  • restore check used, so only existent entities with non-zero used are allowed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from this, we are doing a similar check in setLimit with different error. We should be consistent

  function setLimit(address entity, uint256 limit) external onlyOwner {
    require(_entities.contains(entity), 'ENTITY_DOES_NOT_EXIST');

@DhairyaSethi DhairyaSethi changed the base branch from main to feat/remote-gsm-TL August 25, 2025 14:41
@miguelmtzinf miguelmtzinf merged commit 8ebe1b0 into aave-dao:feat/remote-gsm-TL Aug 27, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants