-
Notifications
You must be signed in to change notification settings - Fork 9
Remote GSM #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
miguelmtzinf
merged 18 commits into
aave-dao:feat/remote-gsm-TL
from
TokenLogic-com-au:remote-gsm
Aug 27, 2025
Merged
Remote GSM #1
miguelmtzinf
merged 18 commits into
aave-dao:feat/remote-gsm-TL
from
TokenLogic-com-au:remote-gsm
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| /// @inheritdoc IGhoReserve | ||
| function use(uint256 amount) external { | ||
| require(_entities.contains(msg.sender), "NOT_ENTITY"); |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this check actually needed? same in restore
- when removing the entity, we check used and limit is 0.
- when adding an entity, it can start with 0 limit.
- use check limit, so only existent entities with non-zero limit are allowed
- restore check used, so only existent entities with non-zero used are allowed
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from this, we are doing a similar check in setLimit with different error. We should be consistent
function setLimit(address entity, uint256 limit) external onlyOwner {
require(_entities.contains(entity), 'ENTITY_DOES_NOT_EXIST');
Certora review - remote gsm
miguelmtzinf
approved these changes
Aug 27, 2025
8ebe1b0
into
aave-dao:feat/remote-gsm-TL
2 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add RemoteGSM Implementation
Abstract methods on GSM