Skip to content

Remote GSM #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 27, 2025
Merged

Remote GSM #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f7af8a0
feat: initial commit
efecarranza Jun 13, 2025
79a723a
feat: finish tests
efecarranza Jun 16, 2025
361c97a
fix: safecast overflow
efecarranza Jun 26, 2025
6032a44
feat: overflow tests
efecarranza Jul 10, 2025
d064534
feat: add entity checks and delete usage
efecarranza Jul 14, 2025
411edf8
fix: update test
efecarranza Jul 14, 2025
c172c2a
feat: add limit check on remove entity
efecarranza Jul 16, 2025
ffcb79b
chore: remove unnecesarry check
efecarranza Jul 17, 2025
6ea6b04
chore: remove deletion
efecarranza Jul 30, 2025
8d895f3
feat: add audit
efecarranza Aug 4, 2025
9165f36
chore: run lint
efecarranza Aug 11, 2025
dc448ce
for PR
nisnislevi Aug 12, 2025
6a193c5
Merge pull request #1 from Certora/certora-squashed
efecarranza Aug 13, 2025
171a3b2
chore: lint certora
efecarranza Aug 14, 2025
edc2a14
Merge remote-tracking branch 'tl/main' into remote-gsm
efecarranza Aug 14, 2025
6102ad8
chore: run ci without if
efecarranza Aug 19, 2025
0987c6d
chore: add all certora ci
efecarranza Aug 19, 2025
fe9a3d5
chore: explicit certora key
efecarranza Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/contracts/facilitators/gsm/GhoReserve.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ contract GhoReserve is Ownable, VersionedInitializable, IGhoReserve {

/// @inheritdoc IGhoReserve
function use(uint256 amount) external {
require(_entities.contains(msg.sender), "NOT_ENTITY");
Copy link
Collaborator

@miguelmtzinf miguelmtzinf Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this check actually needed? same in restore

  • when removing the entity, we check used and limit is 0.
  • when adding an entity, it can start with 0 limit.
  • use check limit, so only existent entities with non-zero limit are allowed
  • restore check used, so only existent entities with non-zero used are allowed

Copy link
Collaborator

@miguelmtzinf miguelmtzinf Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from this, we are doing a similar check in setLimit with different error. We should be consistent

  function setLimit(address entity, uint256 limit) external onlyOwner {
    require(_entities.contains(entity), 'ENTITY_DOES_NOT_EXIST');


GhoUsage storage entity = _ghoUsage[msg.sender];
require(entity.limit >= entity.used + amount, 'LIMIT_EXCEEDED');

Expand All @@ -57,6 +59,8 @@ contract GhoReserve is Ownable, VersionedInitializable, IGhoReserve {

/// @inheritdoc IGhoReserve
function restore(uint256 amount) external {
require(_entities.contains(msg.sender), "NOT_ENTITY");

_ghoUsage[msg.sender].used -= amount.toUint128();
IERC20(GHO_TOKEN).transferFrom(msg.sender, address(this), amount);
emit GhoRestored(msg.sender, amount);
Expand All @@ -79,6 +83,8 @@ contract GhoReserve is Ownable, VersionedInitializable, IGhoReserve {
require(_ghoUsage[entity].used == 0, 'ENTITY_GHO_USED_NOT_ZERO');
require(_entities.remove(entity), 'ENTITY_NOT_REMOVED');

delete _ghoUsage[entity];

emit EntityRemoved(entity);
}

Expand Down
19 changes: 17 additions & 2 deletions tests/unit/TestGhoReserve.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ contract TestGhoReserve is TestGhoBase {
}

function testRevertUseNoCapacity() public {
GHO_RESERVE.addEntity(address(this));
vm.expectRevert('LIMIT_EXCEEDED');
GHO_RESERVE.use(100 ether);
}
Expand Down Expand Up @@ -74,6 +75,11 @@ contract TestGhoReserve is TestGhoBase {
GHO_RESERVE.use(value + 1);
}

function testUseNotEntity() public {
vm.expectRevert("NOT_ENTITY");
GHO_RESERVE.use(1_000 ether);
}

function testRevertRestoreNoWithdrawnAmount() public {
GHO_RESERVE.addEntity(address(this));
GHO_RESERVE.setLimit(address(this), 10_000 ether);
Expand Down Expand Up @@ -123,6 +129,11 @@ contract TestGhoReserve is TestGhoBase {
GHO_RESERVE.restore(value + 1);
}

function testRestoreNotEntity() public {
vm.expectRevert("NOT_ENTITY");
GHO_RESERVE.use(1_000 ether);
}

function testAddEntity() public {
address alice = makeAddr('alice');
vm.expectEmit(true, true, true, true, address(GHO_RESERVE));
Expand All @@ -149,18 +160,22 @@ contract TestGhoReserve is TestGhoBase {
}

function testRemoveEntity() public {
uint256 limit = 1_000_000 ether;
address alice = makeAddr('alice');
vm.expectEmit(true, true, true, true, address(GHO_RESERVE));
emit EntityAdded(alice);
GHO_RESERVE.addEntity(address(alice));
GHO_RESERVE.addEntity(alice);
GHO_RESERVE.setLimit(alice, limit);

assertTrue(GHO_RESERVE.isEntity(alice));
assertEq(GHO_RESERVE.getLimit(alice), limit);

vm.expectEmit(true, true, true, true, address(GHO_RESERVE));
emit EntityRemoved(alice);
GHO_RESERVE.removeEntity(address(alice));
GHO_RESERVE.removeEntity(alice);

assertFalse(GHO_RESERVE.isEntity(alice));
assertEq(GHO_RESERVE.getLimit(alice), 0);
}

function testRemoveEntityNotInSet() public {
Expand Down