Skip to content

WIP: Implement international language support#1494

Draft
abraunegg wants to merge 23 commits into
masterfrom
implement-language-support
Draft

WIP: Implement international language support#1494
abraunegg wants to merge 23 commits into
masterfrom
implement-language-support

Conversation

@abraunegg
Copy link
Copy Markdown
Owner

  • Initial start on implementing international language support

* Initial start on implementing international language support
@abraunegg abraunegg added this to the v2.4.13 milestone May 28, 2021
@abraunegg abraunegg linked an issue May 28, 2021 that may be closed by this pull request
abraunegg added 3 commits May 31, 2021 14:29
* update initial WIP
* updates
* updates
"language": "DE",
"list": [
{
"1": "Keine Benutzer- oder Systemkonfigurationsdatei gefunden, die Anwendungsstandardwerte verwendet",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I just saw this PR, did you by chance create the german translation automatically?
I think at least the first log message sounds a bit off.
I think this sounds better:
"Keine Benutzer- oder Systemkonfigurationsdatei gefunden, es werden die Standardwerte verwendet"

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oohjio
Many thanks for looking at this PR in its very early stage of development.

This is a WIP at the moment. The DE.json is just a 'google' translate of the first few messages, so that I can ensure, when building the PR (as it is not complete), is able to provide the right 'translations' for the language being selected. I could have also used dummy text (eg 'asdfasdfasfdasfdasdf') .. but I didnt.

When this PR is ready, there will only be the EN-US.json file, with the community able to provide a language.json file, which then can be used / loaded into the application for folks to use.

Please keep an eye on this, and if you are interested in providing the DE.json when the main code changes are done, please create / update the file so that this feature can launch with accurate & correct language translations for Deutsche.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abraunegg
Thanks for the reply.
I see, that makes sense,
Will keep an eye on this.

@abraunegg abraunegg modified the milestones: v2.4.13, v2.4.14 Jul 10, 2021
@norbusan
Copy link
Copy Markdown
Collaborator

Hi Alex
I just looked into this and thought wouldn't it be better to use the default msgfmt/gettext style approach, and the https://github.com/FreeSlave/mofile library? That way we could profit from normal translation environment (editors, cloud translations, ...) - just as an idea ...

@abraunegg
Copy link
Copy Markdown
Owner Author

abraunegg commented Jul 13, 2021

@norbusan

Hi Alex
I just looked into this and thought wouldn't it be better to use the default msgfmt/gettext style approach, and the https://github.com/FreeSlave/mofile library? That way we could profit from normal translation environment (editors, cloud translations, ...) - just as an idea ...

Always happy for other ideas / alternate approaches

Looking at https://github.com/FreeSlave/mofile/blob/master/examples/ru.po - that is 'kind of' the approach currently taken - that is - key value pairs.

What I need to do, is get v2.4.13 out, then get back to finishing the PR with my current line of thinking - and see if that works, if not, happy to look at other approaches.

The approach I have (which the PR is a mess on here as compared to what I have locally) is that the translation file is separate - thus can be updated / amended by the end user, restart the application and the new translations are used.

@abraunegg abraunegg mentioned this pull request Jul 23, 2021
Update PR
@abraunegg abraunegg modified the milestones: v2.4.14, v2.4.15, v2.4.16 Nov 22, 2021
@abraunegg abraunegg modified the milestones: v2.4.16, v2.5.x Mar 9, 2022
@abraunegg abraunegg mentioned this pull request Apr 3, 2024
@tianmiao8152
Copy link
Copy Markdown

This PR is still in progress? I'm willing to help with the translation of the Chinese part (including zh-cn and zh-hans, zh-hans is also called zh-tw). This PR is really exciting, it seems like it can start the alpha test?

@abraunegg
Copy link
Copy Markdown
Owner Author

This PR is still in progress? I'm willing to help with the translation of the Chinese part (including zh-cn and zh-hans, zh-hans is also called zh-tw). This PR is really exciting, it seems like it can start the alpha test?

This PR is not aligned to v2.5.x

It provided an insight on providing international language support.

This will be looked at again, but not in 2025.

@abraunegg abraunegg marked this pull request as draft July 1, 2025 23:15
@abraunegg abraunegg closed this Apr 28, 2026
@abraunegg abraunegg reopened this Apr 28, 2026
@github-actions
Copy link
Copy Markdown

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Unrecognized words (35)
accuratly
Attemtping
BBE
BNTA
createing
ctag
dfd
direcory
edgecase
exluded
fbbc
Generage
JFOEE
localpath
MDA
MDEu
MTY
occured
ODcw
ojects
Permisions
possability
ppp
recursivly
requried
rty
RUNBITEw
sucessful
theis
unsynced
vdebug
VDQSEx
Vianet
vlog
ZENTNCRTh
To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:abraunegg/onedrive.git repository
on the master branch (ℹ️ how do I use this?):

git fetch 'https://github.com/abraunegg/onedrive' refs/heads/'master':refs/private/check-spelling-merge-base &&
git checkout 'implement-language-support' &&
git merge -m 'Merge master' 'refs/private/check-spelling-merge-base' &&
git push . :'refs/private/check-spelling-merge-base' &&
curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/abraunegg/onedrive/actions/runs/25031601946/attempts/1' &&
git commit -m 'Update check-spelling metadata'

@tianmiao8152
Copy link
Copy Markdown

is ready?

@abraunegg
Copy link
Copy Markdown
Owner Author

@tianmiao8152

is ready?

No ... the PR somehow got closed.

It will be looked at once 'on-demand' is done.

Pathway:

GitHub CI Testing -> Hash Streaming -> On Demand -> Language Support

@tianmiao8152
Copy link
Copy Markdown

@abraunegg
Well, I’m looking forward to this PR
If this PR is completed, I will participate in the Chinese localization work as soon as possible
although AI should now be able to achieve full i18n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: International Language Support

3 participants