fix reversed operand in ShouldPickFirstSymbol tie-break#2110
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShouldPickFirstSymbol breaks ties between two symbols that cover the same address, but it reads bind2 and type2 from symbol1 rather than symbol2, so the weak-versus-strong and typed-versus-untyped comparisons each test a value against itself and can never fire. The practical effect is that when a weak alias and a global symbol share an address the symbolizer may report the weak alias (or an untyped entry) instead of the canonical name, because selection then falls through to the size check and finally to picking whichever symbol happened to be seen first in the table. This reads the second operand from symbol2 so the intended preference actually takes effect; the size comparison in between was already using both operands correctly.