Skip to content

fix reversed operand in ShouldPickFirstSymbol tie-break#2110

Open
dxbjavid wants to merge 1 commit into
abseil:masterfrom
dxbjavid:symbolize-tiebreak-operand
Open

fix reversed operand in ShouldPickFirstSymbol tie-break#2110
dxbjavid wants to merge 1 commit into
abseil:masterfrom
dxbjavid:symbolize-tiebreak-operand

Conversation

@dxbjavid

Copy link
Copy Markdown
Contributor

ShouldPickFirstSymbol breaks ties between two symbols that cover the same address, but it reads bind2 and type2 from symbol1 rather than symbol2, so the weak-versus-strong and typed-versus-untyped comparisons each test a value against itself and can never fire. The practical effect is that when a weak alias and a global symbol share an address the symbolizer may report the weak alias (or an untyped entry) instead of the canonical name, because selection then falls through to the size check and finally to picking whichever symbol happened to be seen first in the table. This reads the second operand from symbol2 so the intended preference actually takes effect; the size comparison in between was already using both operands correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant