Skip to content

fix reversed operand in ShouldPickFirstSymbol tie-break #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dxbjavid wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix reversed operand in ShouldPickFirstSymbol tie-break #2110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions absl/debugging/symbolize_elf.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ static bool ShouldPickFirstSymbol(const ElfW(Sym) & symbol1,
// If one of the symbols is weak and the other is not, pick the one
// this is not a weak symbol.
char bind1 = ELF_ST_BIND(symbol1.st_info);
char bind2 = ELF_ST_BIND(symbol1.st_info);
char bind2 = ELF_ST_BIND(symbol2.st_info);
if (bind1 == STB_WEAK && bind2 != STB_WEAK) return false;
if (bind2 == STB_WEAK && bind1 != STB_WEAK) return true;

Expand All @@ -728,7 +728,7 @@ static bool ShouldPickFirstSymbol(const ElfW(Sym) & symbol1,
// If one of the symbols has no type and the other is not, pick the
// one that has a type.
char type1 = ELF_ST_TYPE(symbol1.st_info);
char type2 = ELF_ST_TYPE(symbol1.st_info);
char type2 = ELF_ST_TYPE(symbol2.st_info);
if (type1 != STT_NOTYPE && type2 == STT_NOTYPE) {
return true;
}
Expand Down