feat(*): responsive footer for small screens - I133#190
Merged
DianaLease merged 4 commits intoaccordproject:mainfrom Mar 7, 2025
Merged
Conversation
Signed-off-by: Dharma Teja <dteja2468@gmail.com>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DianaLease
requested changes
Mar 7, 2025
Member
DianaLease
left a comment
DianaLease
left a comment
There was a problem hiding this comment.
One comment. Otherwise looks good!
src/App.tsx
Outdated
| Best viewed on desktop | ||
|
|
||
| </div> | ||
| )} |
Member
There was a problem hiding this comment.
This whole section (lines 189-200) can now be removed.
Contributor
Author
There was a problem hiding this comment.
yes, silly me, that's done now. please check.
Signed-off-by: Dharma Teja <dteja2468@gmail.com>
teja-pola
force-pushed
the
teja/133/responsive-footer-for-small-breakpoints
branch
from
dc34978 to
59f54e5
Compare
Signed-off-by: Dharma Teja <dteja2468@gmail.com>
5 tasks
Signed-off-by: Dharma Teja <dteja2468@gmail.com>
Contributor
Author
|
Great, all tests passed. @DianaLease Can you please merge if everything is alright. |
Member
Merged, thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
Summary
-This PR improves the responsiveness and appearance of the footer to ensure a better user experience on different screen sizes.
Changes
-- Made the footer collapsible on smaller screens with a visible "Expand Footer" button.
Flags
-none
Screenshots or Video
Before
After
Untitled.video.-.Made.with.Clipchamp.mp4
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname