Typed database configuration getters for EEG/physiology #1360
+128
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language: Python
MaximeBICMTL
added
Category: Refactor
MaximeBICMTL
force-pushed
the
eeg_orm_config
branch
2 times, most recently
from
30f3bb3 to
fdad96a
Compare
MaximeBICMTL
added
the
Pipeline: BIDS importer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract the EEG/phyisology-related typed database configuration getters from #1335 and adopt them in the current EEG/phyisology pipelines.
Details
envparameter to theEegandPhysiologicalconstructors to access the typed database abstraction.lib.config.lib.config.get_*instead of the oldConfigobjects to get the related configuration values.Future works
The next PR (which builds upon this one and #1359) will be to factorize the chunking subscript calling.