Skip to content

refactor: serve Swagger UI at /docs and redirect /swagger requests#174

Merged
GaballaGit merged 1 commit into
acmcsufoss:mainfrom
MarkRyanGarcia:feat/171/change-docs-route
Mar 8, 2026
Merged

refactor: serve Swagger UI at /docs and redirect /swagger requests#174
GaballaGit merged 1 commit into
acmcsufoss:mainfrom
MarkRyanGarcia:feat/171/change-docs-route

Conversation

@MarkRyanGarcia
Copy link
Copy Markdown
Contributor

No description provided.

@TheJolman TheJolman force-pushed the feat/171/change-docs-route branch from 7dc5ed5 to a57639f Compare March 7, 2026 17:00
Comment thread internal/api/routes/root.go
Copy link
Copy Markdown
Member

@GaballaGit GaballaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking with Josh I will go ahead and approve this PR.

While true that a double redirect would be slower, browser caching will effectively eliminate the difference in time. Second, I think the issue I was concerned about, redirect chains, will not occur. As well as josh bringing up that /docs being the source of truth for our documentation will be beneficial for us if in the future we move to fugeo.

@GaballaGit GaballaGit merged commit dfbd400 into acmcsufoss:main Mar 8, 2026
1 of 2 checks passed
@GaballaGit
Copy link
Copy Markdown
Member

Amazing job on your first PR!!

@TheJolman
Copy link
Copy Markdown
Collaborator

closes #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants