refactor: serve Swagger UI at /docs and redirect /swagger requests#174
Merged
GaballaGit merged 1 commit intoMar 8, 2026
Merged
Conversation
7dc5ed5 to
a57639f
Compare
GaballaGit
requested changes
Mar 7, 2026
TheJolman
approved these changes
Mar 7, 2026
GaballaGit
approved these changes
Mar 8, 2026
Member
GaballaGit
left a comment
There was a problem hiding this comment.
After talking with Josh I will go ahead and approve this PR.
While true that a double redirect would be slower, browser caching will effectively eliminate the difference in time. Second, I think the issue I was concerned about, redirect chains, will not occur. As well as josh bringing up that /docs being the source of truth for our documentation will be beneficial for us if in the future we move to fugeo.
Member
|
Amazing job on your first PR!! |
Collaborator
|
closes #171 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.