Make header "Connect wallet" button primary - #959
Open
cairomassimo wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kpyszkowski
requested changes
Sep 1, 2025
| @@ -67,9 +67,7 @@ export default function ConnectWallet() { | |||
| return ( | |||
| <Button | |||
| size="lg" | |||
Contributor
There was a problem hiding this comment.
Changing variant changes also the size which is not desirable.
It should be addressed in the theme so size props controls the size and variant props controls the appearance.
Let's enforce the height of old button as a workaround with the proper TODO comment.
Suggested change
| size="lg" | |
| size="lg" | |
| {/* TODO: Revisit Buttons theme and separate appearance (variant) from the size */} | |
| height="48px" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ACR-34