Skip to content

Make header "Connect wallet" button primary #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cairomassimo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make header "Connect wallet" button primary #959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
559da01
Make header "Connect wallet" button primary
cairomassimo Jul 31, 2025
c60c1fa
Merge branch 'main' into massimocairo/acr-34-recolor-connect-wallet-b…
nkuba Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dapp/src/components/Header/ConnectWallet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@ export default function ConnectWallet() {
return (
<Button
size="lg"

@kpyszkowski kpyszkowski Sep 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing variant changes also the size which is not desirable.
It should be addressed in the theme so size props controls the size and variant props controls the appearance.

Let's enforce the height of old button as a workaround with the proper TODO comment.

Suggested change
size="lg"
size="lg"
{/* TODO: Revisit Buttons theme and separate appearance (variant) from the size */}
height="48px"

variant="card"
color="text.primary"
leftIcon={<Icon as={BitcoinIcon} boxSize={6} color="acre.50" />}
leftIcon={<Icon as={BitcoinIcon} boxSize={6} />}
onClick={() => handleConnectWallet(false)}
{...((modalType === MODAL_TYPES.CONNECT_WALLET ||
isOpenGlobalErrorModal) && {
Expand Down
Loading