Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Added tests for Image and SocialLink. #1138

Merged
merged 12 commits into from
Mar 8, 2025

Conversation

mattburnett-repo
Copy link
Member

Contributor checklist


Description

This PR provides tests for the recently-added backend functionality of Image Upload and Social Media Links. There wasn't any test coverage for these two new items before now.

Frontend / Playwright tests need to be written; this should be done soon.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 2382da0
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67cc905f6eab0e0008e3eda4

@mattburnett-repo mattburnett-repo self-assigned this Mar 5, 2025
@mattburnett-repo mattburnett-repo added the feature New feature or request label Mar 5, 2025
@andrewtavis
Copy link
Member

Thanks for this, @mattburnett-repo! Let's shoot to get this in in the coming days or by end of sync on Saturday 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work, @mattburnett-repo, and also for the help reviewing, @cquinn540! 😊

@andrewtavis andrewtavis merged commit 7bc64a9 into activist-org:main Mar 8, 2025
7 checks passed
@mattburnett-repo mattburnett-repo deleted the tests branch March 8, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants